refactoring

1 files changed, 10 insertions, 12 deletions

diff --git a/rhimport-tr b/rhimport-tr
index d86bdb9..3a4ca76 100755
--- a/rhimport-tr
+++ b/rhimport-tr
@@ -22,7 +22,6 @@
 #
 
 use strict;
-use DBI;
 use Date::Calc;
 use XML::Feed;
 use XML::Feed::Entry;
@@ -36,11 +35,6 @@ use HTML::Entities;
 use lib '/usr/local/share/rhimport/';
 use rhimport;
 
-my $DBHOST = "airplay";
-my $DBUSER = "rivendell";
-my $DBPW = "lldriven";
-my $DB = "rivendell";
-
 my $STAT_FILE = $ENV{'HOME'} . "/rhimport-tr.stat";
 my $RSS_URL = "http://cba.fro.at/series/tierrechtsradio/feed?c=Kfs2IoV2Wmd";
 $XML::Feed::MULTIPLE_ENCLOSURES=1;
@@ -58,13 +52,17 @@ my $user = `/usr/bin/id -un`;
 $user =~ s/\n//;
 my $group = "tierrecht";
 
-my $dbh = DBI->connect("DBI:mysql:$DB:$DBHOST","$DBUSER","$DBPW") or die "Database Error: $DBI::errstr";
+my ($dbh, $errorstring) = rhimport::opendb();
+if(!defined $dbh) {
+  print "$errorstring\n";
+  exit 1;
+}
 my @allowed_dbs = rhimport::get_dropboxes($dbh, $user, $group);
 
 my $idx = 0;
 if(scalar(@allowed_dbs) != 1) {
   print "found more or less than 1 Dropbox for this group?!\n";
-  $dbh->disconnect();
+  rhimport::closedb($dbh);
   exit 1;
 }
 my $dropbox = $allowed_dbs[$idx]->{'PATH'};
@@ -73,7 +71,7 @@ my $to_cart = $allowed_dbs[$idx]->{'TO_CART'};
 my @today = Date::Calc::Standard_to_Business(Date::Calc::Today());
 if($today[2] == 5) {
   print "please don't run this script on fridays!\n";
-  $dbh->disconnect();
+  rhimport::closedb($dbh);
   exit 1;
 }
 my @broadcast_day = Date::Calc::Business_to_Standard($today[0], $today[1], 5);
@@ -119,13 +117,13 @@ for my $entry ($feed->entries) {
       my $current_file = `cat $STAT_FILE`;
       if($current_file eq $ff->output_file) {
         print "Already downloaded file of today\n";
-        $dbh->disconnect();
+        rhimport::closedb($dbh);
         exit 0;
       }
       $out_file = $ff->output_file;
       if(!rhimport::check_file_extension($out_file)) {
         print "\n\nThe extension of the matching file '". $out_file . "' seems to be wrong - manual import necessary!!!\n";
-        $dbh->disconnect();
+        rhimport::closedb($dbh);
         exit 1;
       }
 
@@ -171,7 +169,7 @@ my $import_log;
 ($ret, $import_log) = rhimport::import_single($file, $dropbox, $user, 0, $error_cb);
 $log .= $import_log;
 
-$dbh->disconnect();
+rhimport::closedb($dbh);
 
 unlink $file;