From 9666cbf7b7c3f6b9a104203078363c7b29226630 Mon Sep 17 00:00:00 2001 From: Christian Pointner Date: Mon, 28 Dec 2015 04:56:51 +0100 Subject: musicgrid.cgi now uses POST to set and GET to get music grids diff --git a/rh-bin/musicgrid.cgi b/rh-bin/musicgrid.cgi index f2bf9db..5e2888d 100755 --- a/rh-bin/musicgrid.cgi +++ b/rh-bin/musicgrid.cgi @@ -35,7 +35,7 @@ my @clocks = (); my $q = CGI->new; my $username = $q->param('LOGIN_NAME'); my $token = $q->param('PASSWORD'); -my $cmd = $q->param('COMMAND'); +my $cmd = $q->request_method(); sub get_clocks { @@ -83,24 +83,21 @@ if(!defined $username) { } elsif(!defined $token) { $responsecode = 400; $errorstring = "mandatory field PASSWORD is missing"; -} elsif(!defined $cmd) { - $responsecode = 400; - $errorstring = "mandatory field COMMAND is missing"; } else { (my $ctx, $status, $errorstring) = RHRD::rddb::init(); if(defined $ctx) { (my $authenticated, $status, $errorstring) = RHRD::rddb::check_token($ctx, $username, $token); my $authorized = RHRD::rddb::is_musicpools_user($ctx, $username); if($authenticated == 1 && $authorized == 1) { - if($cmd eq "get") { + if($cmd eq "GET") { ($responsecode, $errorstring) = get_clocks($ctx); } - elsif($cmd eq "set") { + elsif($cmd eq "POST") { ($responsecode, $errorstring) = set_clock($ctx); } else { - $responsecode = 400; - $errorstring = "command '$cmd' is unknown"; + $responsecode = 405; + $errorstring = "request method '$cmd' is unknown"; } } elsif($authenticated == 0) { $responsecode = 401; @@ -117,7 +114,7 @@ if(!defined $username) { print "Content-type: application/xml; charset=UTF-8\n"; print "Status: $responsecode\n\n"; -if($cmd eq "set" || $responsecode != 200) { +if($cmd eq "POST" || $responsecode != 200) { print "\n"; print " " . xml_quote($responsecode) . "\n"; print " " . xml_quote($errorstring) . "\n"; -- cgit v0.10.2